perf data convert: Prefer sampled CPU when exporting JSON
authorShawn M. Chapla <schapla@codeweavers.com>
Thu, 26 May 2022 20:14:47 +0000 (16:14 -0400)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 23 Jun 2022 14:54:21 +0000 (11:54 -0300)
When CPU has been explicitly sampled (via --sample-cpu), prefer this
sampled value over the thread CPU value when exporting to JSON.

Signed-off-by: Shawn M. Chapla <schapla@codeweavers.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20220526201506.2028281-1-schapla@codeweavers.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/data-convert-json.c

index f1ab6ed..613d6ae 100644 (file)
@@ -149,6 +149,7 @@ static int process_sample_event(struct perf_tool *tool,
        struct convert_json *c = container_of(tool, struct convert_json, tool);
        FILE *out = c->out;
        struct addr_location al, tal;
+       u64 sample_type = __evlist__combined_sample_type(evsel->evlist);
        u8 cpumode = PERF_RECORD_MISC_USER;
 
        if (machine__resolve(machine, &al, sample) < 0) {
@@ -168,7 +169,9 @@ static int process_sample_event(struct perf_tool *tool,
        output_json_key_format(out, true, 3, "pid", "%i", al.thread->pid_);
        output_json_key_format(out, true, 3, "tid", "%i", al.thread->tid);
 
-       if (al.thread->cpu >= 0)
+       if ((sample_type & PERF_SAMPLE_CPU))
+               output_json_key_format(out, true, 3, "cpu", "%i", sample->cpu);
+       else if (al.thread->cpu >= 0)
                output_json_key_format(out, true, 3, "cpu", "%i", al.thread->cpu);
 
        output_json_key_string(out, true, 3, "comm", thread__comm_str(al.thread));