projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8674ca3
)
dmaengine: mcf-edma: Use struct_size()
author
Christophe JAILLET
<christophe.jaillet@wanadoo.fr>
Sat, 6 May 2023 16:22:06 +0000
(18:22 +0200)
committer
Vinod Koul
<vkoul@kernel.org>
Mon, 21 Aug 2023 05:47:23 +0000
(11:17 +0530)
Use struct_size() instead of hand writing it.
This is less verbose and more informative.
'mcf_chan' is now unused and can be removed. In fact, it is shadowed by
another variable in the 'for' loop below. Keep this one.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link:
https://lore.kernel.org/r/97c2bb1c9b69d0739da3762a7752ae6582c4ad02.1683390112.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/mcf-edma.c
patch
|
blob
|
history
diff --git
a/drivers/dma/mcf-edma.c
b/drivers/dma/mcf-edma.c
index
ebd8733
..
28304dd
100644
(file)
--- a/
drivers/dma/mcf-edma.c
+++ b/
drivers/dma/mcf-edma.c
@@
-180,9
+180,8
@@
static int mcf_edma_probe(struct platform_device *pdev)
{
struct mcf_edma_platform_data *pdata;
struct fsl_edma_engine *mcf_edma;
- struct fsl_edma_chan *mcf_chan;
struct edma_regs *regs;
- int ret, i,
len,
chans;
+ int ret, i, chans;
pdata = dev_get_platdata(&pdev->dev);
if (!pdata) {
@@
-191,8
+190,8
@@
static int mcf_edma_probe(struct platform_device *pdev)
}
chans = pdata->dma_channels;
- len = sizeof(*mcf_edma) + sizeof(*mcf_chan) * chans;
-
mcf_edma = devm_kzalloc(&pdev->dev, len,
GFP_KERNEL);
+ mcf_edma = devm_kzalloc(&pdev->dev, struct_size(mcf_edma, chans, chans),
+
GFP_KERNEL);
if (!mcf_edma)
return -ENOMEM;