playbin: fix suburidecodebin leak

We take a ref before removing which was never freeded.
The element is still alive anyway because the group has its own ref as
well.

Fix a leak with the 'test_suburi_error_wrongproto' test.

https://bugzilla.gnome.org/show_bug.cgi?id=766515

diff --git a/gst/playback/gstplaybin2.c b/gst/playback/gstplaybin2.c
index e939fa6..15fea65 100644 (file)
--- a/gst/playback/gstplaybin2.c
+++ b/gst/playback/gstplaybin2.c
@@ -3017,6 +3017,7 @@ gst_play_bin_handle_message (GstBin * bin, GstMessage * msg)
         gst_object_ref (group->suburidecodebin);
         gst_bin_remove (bin, group->suburidecodebin);
         gst_element_set_locked_state (group->suburidecodebin, FALSE);
+        gst_object_unref (group->suburidecodebin);
 
         GST_SOURCE_GROUP_LOCK (group);
         g_free (group->suburi);