perf record: Use evlist__add_dummy_on_all_cpus() in record__config_text_poke()
authorAdrian Hunter <adrian.hunter@intel.com>
Tue, 24 May 2022 07:54:27 +0000 (10:54 +0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 26 May 2022 15:36:57 +0000 (12:36 -0300)
Use evlist__add_dummy_on_all_cpus() in record__config_text_poke() in
preparation for allowing system-wide events on all CPUs while the user
requested events are on only user requested CPUs.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Leo Yan <leo.yan@linaro.org>
Link: https://lore.kernel.org/r/20220524075436.29144-7-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-record.c

index a5cf6a9..c8a79f3 100644 (file)
@@ -869,7 +869,6 @@ static int record__auxtrace_init(struct record *rec __maybe_unused)
 static int record__config_text_poke(struct evlist *evlist)
 {
        struct evsel *evsel;
-       int err;
 
        /* Nothing to do if text poke is already configured */
        evlist__for_each_entry(evlist, evsel) {
@@ -877,27 +876,13 @@ static int record__config_text_poke(struct evlist *evlist)
                        return 0;
        }
 
-       err = parse_events(evlist, "dummy:u", NULL);
-       if (err)
-               return err;
-
-       evsel = evlist__last(evlist);
+       evsel = evlist__add_dummy_on_all_cpus(evlist);
+       if (!evsel)
+               return -ENOMEM;
 
-       evsel->core.attr.freq = 0;
-       evsel->core.attr.sample_period = 1;
        evsel->core.attr.text_poke = 1;
        evsel->core.attr.ksymbol = 1;
-
-       evsel->core.system_wide = true;
-       evsel->no_aux_samples = true;
        evsel->immediate = true;
-
-       /* Text poke must be collected on all CPUs */
-       perf_cpu_map__put(evsel->core.own_cpus);
-       evsel->core.own_cpus = perf_cpu_map__new(NULL);
-       perf_cpu_map__put(evsel->core.cpus);
-       evsel->core.cpus = perf_cpu_map__get(evsel->core.own_cpus);
-
        evsel__set_sample_bit(evsel, TIME);
 
        return 0;