net: USB: Deletion of unnecessary checks before the function call "kfree"
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 20 Nov 2014 15:11:56 +0000 (16:11 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 21 Nov 2014 20:16:10 +0000 (15:16 -0500)
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/asix_devices.c
drivers/net/usb/hso.c

index 816d511..bf49792 100644 (file)
@@ -487,8 +487,7 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf)
 
 static void ax88772_unbind(struct usbnet *dev, struct usb_interface *intf)
 {
-       if (dev->driver_priv)
-               kfree(dev->driver_priv);
+       kfree(dev->driver_priv);
 }
 
 static const struct ethtool_ops ax88178_ethtool_ops = {
index babda7d..9c5aa92 100644 (file)
@@ -2746,8 +2746,7 @@ exit:
                tty_unregister_device(tty_drv, serial->minor);
                kfree(serial);
        }
-       if (hso_dev)
-               kfree(hso_dev);
+       kfree(hso_dev);
        return NULL;
 
 }