staging: wfx: simplify virt_addr_valid call
authorTom Rix <trix@redhat.com>
Sat, 12 Sep 2020 14:47:19 +0000 (07:47 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Sep 2020 14:28:41 +0000 (16:28 +0200)
Reviewing sram_write_dma_safe(), there are two
identical calls to virt_addr_valid().  The second
call can be simplified by a comparison of variables
set from the first call.

Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20200912144719.13929-1-trix@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wfx/fwio.c

index 22d3b68..c99adb0 100644 (file)
@@ -94,7 +94,7 @@ static int sram_write_dma_safe(struct wfx_dev *wdev, u32 addr, const u8 *buf,
                tmp = buf;
        }
        ret = sram_buf_write(wdev, addr, tmp, len);
-       if (!virt_addr_valid(buf))
+       if (tmp != buf)
                kfree(tmp);
        return ret;
 }