drm/cirrus: Remove format test from cirrus_fb_create()
authorThomas Zimmermann <tzimmermann@suse.de>
Wed, 15 Feb 2023 16:15:11 +0000 (17:15 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 13 Mar 2023 09:36:32 +0000 (10:36 +0100)
The DRM core implements a format check when setting a framebuffer
for a plane. [1] Remove the unnecessary test from cirrus_fb_create().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Link: https://elixir.bootlin.com/linux/v6.1/source/drivers/gpu/drm/drm_atomic.c#L629
Link: https://patchwork.freedesktop.org/patch/msgid/20230215161517.5113-12-tzimmermann@suse.de
drivers/gpu/drm/tiny/cirrus.c

index a483abc..c1ffbbe 100644 (file)
@@ -559,10 +559,6 @@ static struct drm_framebuffer*
 cirrus_fb_create(struct drm_device *dev, struct drm_file *file_priv,
                 const struct drm_mode_fb_cmd2 *mode_cmd)
 {
-       if (mode_cmd->pixel_format != DRM_FORMAT_RGB565 &&
-           mode_cmd->pixel_format != DRM_FORMAT_RGB888 &&
-           mode_cmd->pixel_format != DRM_FORMAT_XRGB8888)
-               return ERR_PTR(-EINVAL);
        if (cirrus_check_size(mode_cmd->width, mode_cmd->height, NULL) < 0)
                return ERR_PTR(-EINVAL);
        return drm_gem_fb_create_with_dirty(dev, file_priv, mode_cmd);