net: fec: use napi_consume_skb() in fec_enet_tx_queue()
authorWei Fang <wei.fang@nxp.com>
Wed, 16 Aug 2023 09:02:42 +0000 (17:02 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 18 Aug 2023 22:17:27 +0000 (15:17 -0700)
Now that the "budget" is passed into fec_enet_tx_queue(), one
optimization we can do is to use napi_consume_skb() to instead
of dev_kfree_skb_any().

Signed-off-by: Wei Fang <wei.fang@nxp.com>
Suggested-by: Alexander H Duyck <alexander.duyck@gmail.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20230816090242.463822-1-wei.fang@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fec_main.c

index f77105f..e23a559 100644 (file)
@@ -1494,7 +1494,7 @@ fec_enet_tx_queue(struct net_device *ndev, u16 queue_id, int budget)
                        }
 
                        /* Free the sk buffer associated with this last transmit */
-                       dev_kfree_skb_any(skb);
+                       napi_consume_skb(skb, budget);
                } else if (txq->tx_buf[index].type == FEC_TXBUF_T_XDP_NDO) {
                        xdp_return_frame_rx_napi(xdpf);
                } else { /* recycle pages of XDP_TX frames */