cifs: Avoid a cast in add_lease_context()
authorVolker Lendecke <vl@samba.org>
Fri, 17 Mar 2023 11:15:22 +0000 (11:15 +0000)
committerSteve French <stfrench@microsoft.com>
Mon, 24 Apr 2023 02:16:57 +0000 (21:16 -0500)
We have the correctly-typed struct smb2_create_req * available in the
caller.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by Ralph Boehme <slow@samba.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/smb2pdu.c

index 875862c..281e0b1 100644 (file)
@@ -2166,10 +2166,11 @@ smb2_parse_contexts(struct TCP_Server_Info *server,
 }
 
 static int
-add_lease_context(struct TCP_Server_Info *server, struct kvec *iov,
+add_lease_context(struct TCP_Server_Info *server,
+                 struct smb2_create_req *req,
+                 struct kvec *iov,
                  unsigned int *num_iovec, u8 *lease_key, __u8 *oplock)
 {
-       struct smb2_create_req *req = iov[0].iov_base;
        unsigned int num = *num_iovec;
 
        iov[num].iov_base = server->ops->create_lease_buf(lease_key, *oplock);
@@ -2811,7 +2812,7 @@ SMB2_open_init(struct cifs_tcon *tcon, struct TCP_Server_Info *server,
                  (oparms->create_options & CREATE_NOT_FILE))
                req->RequestedOplockLevel = *oplock; /* no srv lease support */
        else {
-               rc = add_lease_context(server, iov, &n_iov,
+               rc = add_lease_context(server, req, iov, &n_iov,
                                       oparms->fid->lease_key, oplock);
                if (rc)
                        return rc;