interconnect: msm8974: Ignore return value of icc_provider_del() in .remove()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 18 Jul 2022 12:14:05 +0000 (14:14 +0200)
committerGeorgi Djakov <djakov@kernel.org>
Tue, 16 Aug 2022 13:38:11 +0000 (16:38 +0300)
icc_provider_del() already emits an error message on failure. In this
case letting .remove() return the corresponding error code results in
another error message and the device is removed anyhow. (See
platform_remove().)

So ignore the return value of icc_provider_del() and return 0
unconditionally.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220718121409.171773-5-u.kleine-koenig@pengutronix.de
Signed-off-by: Georgi Djakov <djakov@kernel.org>
drivers/interconnect/qcom/msm8974.c

index 6fa0ad9..5ea192f 100644 (file)
@@ -749,7 +749,9 @@ static int msm8974_icc_remove(struct platform_device *pdev)
 
        icc_nodes_remove(&qp->provider);
        clk_bulk_disable_unprepare(qp->num_clks, qp->bus_clks);
-       return icc_provider_del(&qp->provider);
+       icc_provider_del(&qp->provider);
+
+       return 0;
 }
 
 static const struct of_device_id msm8974_noc_of_match[] = {