Bug TT-66: Remove private ewk_view_javascript_* APIs from browser code 54/43854/9
authork.lis2 <k.lis2@samsung.com>
Tue, 21 Jul 2015 14:09:04 +0000 (16:09 +0200)
committerSungwon Han <sungwon2.han@samsung.com>
Fri, 31 Jul 2015 05:26:09 +0000 (22:26 -0700)
    [Issue#]   https://bugs.tizen.org/jira/browse/TT-66
    [Problem]  Private ewk_view_javascript_ APIs persist in the code
    [Cause]    -
    [Solution] Removejs api calls from the code.
    [Verify]   Calls to ewk_view_javascript_ API are within dead code
               so just run the browser to verify the build was
               correct.

Change-Id: I621f082ffc04c453f27b5068f31cdf8b8b8b7f10
Signed-off-by: k.lis2 <k.lis2@samsung.com>
services/WebKitEngineService/WebView.cpp

index 141f1e7823248cb58d48e58d6e66dbffc38e0d04..f01aebb137637e0c765f51ae511b0186e7e08c0c 100644 (file)
@@ -412,41 +412,6 @@ void WebView::confirmationResult(WebConfirmationPtr confirmation)
         m_confirmationAuthenticationMap.erase(auth);
         break;
     }
-    case WebConfirmation::ConfirmationType::ScriptAlert:
-        // set alert reply
-        ewk_view_javascript_alert_reply(m_ewkView);
-        break;
-    case WebConfirmation::ConfirmationType::ScriptConfirmation: {
-        Eina_Bool result;
-        if (confirmation->getResult() == WebConfirmation::ConfirmationResult::Confirmed)
-            result = EINA_TRUE;
-        else if (confirmation->getResult() == WebConfirmation::ConfirmationResult::Rejected)
-            result = EINA_FALSE;
-        else {
-            BROWSER_LOGE("Wrong ConfirmationResult");
-            break;
-        };
-
-        // set confirm reply
-        ewk_view_javascript_confirm_reply(m_ewkView, result);
-        break;
-    }
-    case WebConfirmation::ConfirmationType::ScriptPrompt: {
-        ScriptPromptPtr prompt = std::dynamic_pointer_cast<ScriptPrompt, WebConfirmation>(confirmation);
-        Eina_Bool result;
-        if (confirmation->getResult() == WebConfirmation::ConfirmationResult::Confirmed)
-            result = EINA_TRUE;
-        else if (confirmation->getResult() == WebConfirmation::ConfirmationResult::Rejected)
-            result = EINA_FALSE;
-        else {
-            BROWSER_LOGE("Wrong ConfirmationResult");
-            break;
-        };
-
-        // set prompt reply
-        ewk_view_javascript_prompt_reply(m_ewkView, prompt->getUserData().c_str());
-        break;
-    }
     default:
         break;
     }