projects
/
sdk
/
emulator
/
qemu.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
18557e6
)
mptsas: fix wrong formula
author
Paolo Bonzini
<pbonzini@redhat.com>
Tue, 16 Feb 2016 07:49:15 +0000
(08:49 +0100)
committer
Paolo Bonzini
<pbonzini@redhat.com>
Tue, 16 Feb 2016 15:41:22 +0000
(16:41 +0100)
MPI_DOORBELL_WHO_INIT_SHIFT is being repeated twice. Reported
by Coverity.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/scsi/mptsas.c
patch
|
blob
|
history
diff --git
a/hw/scsi/mptsas.c
b/hw/scsi/mptsas.c
index
1ce3226
..
499c146
100644
(file)
--- a/
hw/scsi/mptsas.c
+++ b/
hw/scsi/mptsas.c
@@
-824,7
+824,7
@@
static uint32_t mptsas_doorbell_read(MPTSASState *s)
{
uint32_t ret;
- ret = (s->who_init << MPI_DOORBELL_WHO_INIT_SHIFT) & MPI_DOORBELL_WHO_INIT_
SHIFT
;
+ ret = (s->who_init << MPI_DOORBELL_WHO_INIT_SHIFT) & MPI_DOORBELL_WHO_INIT_
MASK
;
ret |= s->state;
switch (s->doorbell_state) {
case DOORBELL_NONE: