drm/mcde: Remove redundant error printing in mcde_dsi_probe()
authorZhen Lei <thunder.leizhen@huawei.com>
Tue, 11 May 2021 09:13:44 +0000 (17:13 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 21 May 2021 23:58:27 +0000 (01:58 +0200)
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210511091344.4508-1-thunder.leizhen@huawei.com
drivers/gpu/drm/mcde/mcde_dsi.c

index b3fd350..5aade1d 100644 (file)
@@ -1196,10 +1196,8 @@ static int mcde_dsi_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        d->regs = devm_ioremap_resource(dev, res);
-       if (IS_ERR(d->regs)) {
-               dev_err(dev, "no DSI regs\n");
+       if (IS_ERR(d->regs))
                return PTR_ERR(d->regs);
-       }
 
        dsi_id = readl(d->regs + DSI_ID_REG);
        dev_info(dev, "HW revision 0x%08x\n", dsi_id);