Upgrade unit tests

- Add some negative testcases for coverage.
- Fix testcase to use right API.

Change-Id: I1b02069eea1cb1cf4c1675926018322ed33d4253
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>

diff --git a/test/unit_tests/test_theme.cc b/test/unit_tests/test_theme.cc
index 1ef386c8e0ea3f1697c0f97fd4b8f2ff5457941b..b453a9ae806ebb24c18e46ba10c31143aa0cd75e 100644 (file)
--- a/test/unit_tests/test_theme.cc
+++ b/test/unit_tests/test_theme.cc
@@ -149,7 +149,7 @@ TEST_F(ThemeTest, Theme_GetResolution) {
 
 TEST_F(ThemeTest, Theme_GetResolution_N) {
   char *resolution;
-  int ret = theme_get_title(nullptr, &resolution);
+  int ret = theme_get_resolution(nullptr, &resolution);
 
   EXPECT_EQ(ret, THEME_MANAGER_ERROR_INVALID_PARAMETER);
 }
@@ -217,7 +217,18 @@ TEST_F(ThemeTest, Theme_GetString_N) {
   EXPECT_EQ(ret, THEME_MANAGER_ERROR_INVALID_PARAMETER);
 }
 
-TEST_F(ThemeTest, Theme_GetStringArray) {
+TEST_F(ThemeTest, Theme_GetString_N2) {
+  std::shared_ptr<ThemeInfo> info(
+      new ThemeInfo());
+
+  theme_h handle = static_cast<void*>(&info);
+  char *str;
+  int ret = theme_get_string(handle, "stringkey", &str);
+
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_IO_ERROR);
+}
+
+TEST_F(ThemeTest, Theme_GetStringArray_P) {
   std::shared_ptr<ThemeInfo> info(
       new ThemeInfo(b_));
 
@@ -234,6 +245,19 @@ TEST_F(ThemeTest, Theme_GetStringArray) {
   free(strarr);
 }
 
+TEST_F(ThemeTest, Theme_GetStringArray_P2) {
+  std::shared_ptr<ThemeInfo> info(
+      new ThemeInfo());
+
+  theme_h handle = static_cast<void*>(&info);
+  char **strarr;
+  int count;
+  int ret = theme_get_string_array(handle, "arraykey", &strarr, &count);
+
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_NONE);
+  EXPECT_EQ(count, 0);
+}
+
 TEST_F(ThemeTest, Theme_GetStringArray_N) {
   char **strarr;
   int count;
@@ -280,6 +304,34 @@ TEST_F(ThemeTest, Theme_GetFloat_N) {
   EXPECT_EQ(ret, THEME_MANAGER_ERROR_INVALID_PARAMETER);
 }
 
+TEST_F(ThemeTest, Theme_Clone) {
+  std::shared_ptr<ThemeInfo> info(
+      new ThemeInfo(b_));
+  theme_h handle = static_cast<void*>(&info);
+  theme_h handle_clone;
+
+  int ret = theme_clone(handle, &handle_clone);
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_NONE);
+  ret = theme_destroy(handle_clone);
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_NONE);
+}
+
+TEST_F(ThemeTest, Theme_Clone_N1) {
+  std::shared_ptr<ThemeInfo> info(
+      new ThemeInfo(b_));
+  theme_h handle = static_cast<void*>(&info);
+
+  int ret = theme_clone(handle, nullptr);
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_INVALID_PARAMETER);
+}
+
+TEST_F(ThemeTest, Theme_Clone_N2) {
+  theme_h handle;
+
+  int ret = theme_clone(nullptr, &handle);
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_INVALID_PARAMETER);
+}
+
 TEST_F(ThemeTest, Theme_GetBool) {
   std::shared_ptr<ThemeInfo> info(
       new ThemeInfo(b_));
@@ -309,4 +361,9 @@ TEST_F(ThemeTest, Theme_GetBool_N2) {
 
   EXPECT_EQ(ret, THEME_MANAGER_ERROR_NONE);
   EXPECT_EQ(val, false);
+}
+
+TEST_F(ThemeTest, Theme_Destroy_N) {
+  int ret = theme_destroy(nullptr);
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_INVALID_PARAMETER);
 }
\ No newline at end of file

diff --git a/test/unit_tests/test_theme_loader.cc b/test/unit_tests/test_theme_loader.cc
index dd453801f6cb1b28c5b71f2d2ea65fc4199e6134..6a514f88af988e16e9b2443136e671ecefeb3410 100644 (file)
--- a/test/unit_tests/test_theme_loader.cc
+++ b/test/unit_tests/test_theme_loader.cc
@@ -76,6 +76,12 @@ TEST_F(ThemeLoaderTest, Create) {
   loader_handle_ = handle;
 }
 
+TEST_F(ThemeLoaderTest, Create_N) {
+  int ret = theme_loader_create(nullptr);
+
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_INVALID_PARAMETER);
+}
+
 TEST_F(ThemeLoaderTest, SetCurrent) {
   EXPECT_CALL(GetMock<GioMock>(),
       g_dbus_message_new_method_call(_, _, _, _)).
@@ -102,6 +108,13 @@ TEST_F(ThemeLoaderTest, SetCurrent) {
   EXPECT_EQ(ret, THEME_MANAGER_ERROR_NONE);
 }
 
+TEST_F(ThemeLoaderTest, SetCurrent_N) {
+  int ret;
+
+  ret = theme_loader_set_current(nullptr, "id");
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_INVALID_PARAMETER);
+}
+
 TEST_F(ThemeLoaderTest, LoadCurrent) {
   EXPECT_CALL(GetMock<GioMock>(),
       g_dbus_message_new_method_call(_, _, _, _)).
@@ -132,6 +145,11 @@ TEST_F(ThemeLoaderTest, LoadCurrent) {
   theme_destroy(theme_handle);
 }
 
+TEST_F(ThemeLoaderTest, LoadCurrent_N) {
+  int ret = theme_loader_load_current(loader_handle_, nullptr);
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_INVALID_PARAMETER);
+}
+
 TEST_F(ThemeLoaderTest, Load) {
   EXPECT_CALL(GetMock<GioMock>(),
       g_dbus_message_new_method_call(StrEq("org.tizen.ThemeManager"),
@@ -164,6 +182,14 @@ TEST_F(ThemeLoaderTest, Load) {
   theme_destroy(theme_handle);
 }
 
+TEST_F(ThemeLoaderTest, Load_N) {
+  theme_h theme_handle;
+  int ret;
+
+  ret = theme_loader_load(loader_handle_, nullptr, &theme_handle);
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_INVALID_PARAMETER);
+}
+
 TEST_F(ThemeLoaderTest, QueryID) {
   EXPECT_CALL(GetMock<GioMock>(), g_dbus_message_new_method_call(_, _, _, _)).
       WillOnce(Return(reinterpret_cast<GDBusMessage*>(1)));
@@ -191,6 +217,15 @@ TEST_F(ThemeLoaderTest, QueryID) {
   EXPECT_EQ(count, 0);
 }
 
+TEST_F(ThemeLoaderTest, QueryID_N) {
+  int ret;
+  int count;
+  char **ids;
+
+  ret = theme_loader_query_id(nullptr, &ids, &count);
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_INVALID_PARAMETER);
+}
+
 TEST_F(ThemeLoaderTest, AddEvent) {
   theme_loader_event_h event_handle;
   int ret;
@@ -203,6 +238,15 @@ TEST_F(ThemeLoaderTest, AddEvent) {
   event_handle_ = event_handle;
 }
 
+TEST_F(ThemeLoaderTest, AddEvent_N) {
+  theme_loader_event_h event_handle;
+  int ret;
+
+  ret = theme_loader_add_event(loader_handle_, nullptr,
+      nullptr, &event_handle);
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_INVALID_PARAMETER);
+}
+
 TEST_F(ThemeLoaderTest, RemoveEvent) {
   int ret;
 
@@ -210,7 +254,17 @@ TEST_F(ThemeLoaderTest, RemoveEvent) {
   EXPECT_EQ(ret, THEME_MANAGER_ERROR_NONE);
 }
 
+TEST_F(ThemeLoaderTest, RemoveEvent_N) {
+  int ret = theme_loader_remove_event(nullptr, event_handle_);
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_INVALID_PARAMETER);
+}
+
 TEST_F(ThemeLoaderTest, Destroy) {
   int ret = theme_loader_destroy(loader_handle_);
   EXPECT_EQ(ret, THEME_MANAGER_ERROR_NONE);
+}
+
+TEST_F(ThemeLoaderTest, Destroy_N) {
+  int ret = theme_loader_destroy(nullptr);
+  EXPECT_EQ(ret, THEME_MANAGER_ERROR_INVALID_PARAMETER);
 }
\ No newline at end of file