staging: dgap: tty.c: removes smatch warning "ignoring unreachable code"
authorLidza Louina <lidza.louina@gmail.com>
Mon, 23 Sep 2013 22:47:14 +0000 (18:47 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Sep 2013 23:18:10 +0000 (16:18 -0700)
This patch removes this smatch warning:
info: ignoring unreachable code.

There were instances where there was extra code after
the default action in switch statements. These default
actions ended with a break so the code wasn't being run
at anytime. This patch removes that extra code.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/dgap/dgap_tty.c

index 2b26152..7f909b8 100644 (file)
@@ -3513,10 +3513,6 @@ static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
                        return(-EINVAL);
                }
 
-               DGAP_UNLOCK(ch->ch_lock, lock_flags2);
-               DGAP_UNLOCK(bd->bd_lock, lock_flags);
-               return(-ENOIOCTLCMD);
-
        case DIGI_GETA:
                /* get information for ditty */
                DGAP_UNLOCK(ch->ch_lock, lock_flags2);
@@ -3586,12 +3582,4 @@ static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
 
                return(-ENOIOCTLCMD);
        }
-
-       DGAP_UNLOCK(ch->ch_lock, lock_flags2);
-       DGAP_UNLOCK(bd->bd_lock, lock_flags);
-
-       DPR_IOCTL(("dgap_tty_ioctl end - cmd %s (%x), arg %lx\n", 
-               dgap_ioctl_name(cmd), cmd, arg));
-                        
-       return(0);
 }