projects
/
platform
/
upstream
/
llvm.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4629afa
)
[BasicAA] Remove stale FIXME (NFC)
author
Nikita Popov
<nikita.ppv@gmail.com>
Sat, 21 Nov 2020 19:05:47 +0000
(20:05 +0100)
committer
Nikita Popov
<nikita.ppv@gmail.com>
Sat, 21 Nov 2020 19:07:26 +0000
(20:07 +0100)
If aliasGEP returns MayAlias, the code does fall through to
aliasPHI etc, so this FIXME is no longer applicable.
llvm/lib/Analysis/BasicAliasAnalysis.cpp
patch
|
blob
|
history
diff --git
a/llvm/lib/Analysis/BasicAliasAnalysis.cpp
b/llvm/lib/Analysis/BasicAliasAnalysis.cpp
index
944ff8e
..
c7736e7
100644
(file)
--- a/
llvm/lib/Analysis/BasicAliasAnalysis.cpp
+++ b/
llvm/lib/Analysis/BasicAliasAnalysis.cpp
@@
-1746,8
+1746,6
@@
AliasResult BasicAAResult::aliasCheck(const Value *V1, LocationSize V1Size,
if (!Pair.second)
return Pair.first->second;
- // FIXME: This isn't aggressively handling alias(GEP, PHI) for example: if the
- // GEP can't simplify, we don't even look at the PHI cases.
if (const GEPOperator *GV1 = dyn_cast<GEPOperator>(V1)) {
AliasResult Result =
aliasGEP(GV1, V1Size, V1AAInfo, V2, V2Size, V2AAInfo, O1, O2, AAQI);