habanalabs: replace usage of found with dedicated list iterator variable

To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/misc/habanalabs/common/command_submission.c b/drivers/misc/habanalabs/common/command_submission.c
index d93ef9f..32051f0 100644 (file)
--- a/drivers/misc/habanalabs/common/command_submission.c
+++ b/drivers/misc/habanalabs/common/command_submission.c
@@ -407,8 +407,7 @@ static void staged_cs_put(struct hl_device *hdev, struct hl_cs *cs)
 
 static void cs_handle_tdr(struct hl_device *hdev, struct hl_cs *cs)
 {
-       bool next_entry_found = false;
-       struct hl_cs *next, *first_cs;
+       struct hl_cs *next = NULL, *iter, *first_cs;
 
        if (!cs_needs_timeout(cs))
                return;
@@ -443,13 +442,13 @@ static void cs_handle_tdr(struct hl_device *hdev, struct hl_cs *cs)
        spin_lock(&hdev->cs_mirror_lock);
 
        /* queue TDR for next CS */
-       list_for_each_entry(next, &hdev->cs_mirror_list, mirror_node)
-               if (cs_needs_timeout(next)) {
-                       next_entry_found = true;
+       list_for_each_entry(iter, &hdev->cs_mirror_list, mirror_node)
+               if (cs_needs_timeout(iter)) {
+                       next = iter;
                        break;
                }
 
-       if (next_entry_found && !next->tdr_active) {
+       if (next && !next->tdr_active) {
                next->tdr_active = true;
                schedule_delayed_work(&next->work_tdr, next->timeout_jiffies);
        }