Minor Cleanup
authorThanik Kanagaratnam <thanik1234@gmail.com>
Mon, 19 Feb 2024 05:48:48 +0000 (00:48 -0500)
committerGleb Balykov/Advanced System SW Lab /SRR/Staff Engineer/Samsung Electronics <g.balykov@samsung.com>
Mon, 18 Mar 2024 12:14:37 +0000 (15:14 +0300)
src/metadata/modules.cpp

index 4e1f4b4da34f2e0c1472cd028bfa1ab74278049c..55507e075f773890a1483d17914a4a9a211a14d6 100644 (file)
@@ -495,20 +495,17 @@ static HRESULT LoadSymbols(IMetaDataImport *pMD, ICorDebugModule *pModule, VOID
 
     std::vector<unsigned char> peBuf;
     ULONG64 peBufAddress = 0;
-    if (isInMemory)
+    if (isInMemory && peAddress != 0 && peSize != 0)
     {
         ToRelease<ICorDebugProcess> process;
         IfFailRet(pModule->GetProcess(&process));
 
-        if (peAddress != 0 && peSize != 0)
-        {
-            peBuf.resize(peSize);
-            peBufAddress = (ULONG64)&peBuf[0];
-            SIZE_T read = 0;
-            IfFailRet(process->ReadMemory(peAddress, peSize, &peBuf[0], &read));
-            if (read != peSize)
-                return E_FAIL;
-        }
+        peBuf.resize(peSize);
+        peBufAddress = (ULONG64)&peBuf[0];
+        SIZE_T read = 0;
+        IfFailRet(process->ReadMemory(peAddress, peSize, &peBuf[0], &read));
+        if (read != peSize)
+            return E_FAIL;
     }
 
     return Interop::LoadSymbolsForPortablePDB(