tools: PCI: Fix fd leakage
authorHewenliang <hewenliang4@huawei.com>
Sat, 26 Oct 2019 01:35:55 +0000 (21:35 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Jan 2020 18:48:54 +0000 (19:48 +0100)
commit 3c379a59b4795d7279d38c623e74b9790345a32b upstream.

We should close fd before the return of run_test.

Fixes: 3f2ed8134834 ("tools: PCI: Add a userspace tool to test PCI endpoint")
Signed-off-by: Hewenliang <hewenliang4@huawei.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/pci/pcitest.c

index cb1e51f..32b7c6f 100644 (file)
@@ -129,6 +129,7 @@ static int run_test(struct pci_test *test)
        }
 
        fflush(stdout);
+       close(fd);
        return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
 }