openh264: memcmp return value 0 means match

Commit e2aa76db79328b7f61536dd19d0373cf920395ad introduced version
check guard for OpenH264 binary. There was a boolean error in
memcmp so matching OpenH264 was erroneously rejected.
Fixes #1278

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1219>

diff --git a/ext/openh264/gstopenh264plugin.c b/ext/openh264/gstopenh264plugin.c
index 10b0d4f071dab9ea71be26e07fe265bbc1591192..d659a488c8b436635bf2199eb06aed43f72364cc 100644 (file)
--- a/ext/openh264/gstopenh264plugin.c
+++ b/ext/openh264/gstopenh264plugin.c
@@ -47,7 +47,7 @@ plugin_init (GstPlugin * plugin)
    * ABI without changing the SONAME.
    */
   OpenH264Version libver = WelsGetCodecVersion ();
-  if (memcmp (&libver, &g_stCodecVersion, sizeof (libver))) {
+  if (memcmp (&libver, &g_stCodecVersion, sizeof (libver)) == 0) {
     gst_element_register (plugin, "openh264dec", GST_RANK_MARGINAL,
         GST_TYPE_OPENH264DEC);
     gst_element_register (plugin, "openh264enc", GST_RANK_MARGINAL,