build: give explicit error when unable to setuid on install.
authorJon A. Cruz <jonc@osg.samsung.com>
Fri, 10 Apr 2015 00:52:56 +0000 (17:52 -0700)
committerPekka Paalanen <pekka.paalanen@collabora.co.uk>
Fri, 10 Apr 2015 06:52:13 +0000 (09:52 +0300)
Added build error message when 'make install' is run as non-root
and the --disable-setuid-install configuration option has not been
used.

Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
Tested-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Makefile.am

index 4aa41ff..c1347b8 100644 (file)
@@ -161,8 +161,15 @@ weston_launch_LDADD = $(PAM_LIBS) $(SYSTEMD_LOGIN_LIBS) $(LIBDRM_LIBS)
 
 if ENABLE_SETUID_INSTALL
 install-exec-hook:
-       chown root $(DESTDIR)$(bindir)/weston-launch
-       chmod u+s $(DESTDIR)$(bindir)/weston-launch
+       can_suid_files=no; \
+       chown root $(DESTDIR)$(bindir)/weston-launch \
+               && chmod u+s $(DESTDIR)$(bindir)/weston-launch \
+               && can_suid_files=yes;\
+       if test $$can_suid_files=no; then \
+               echo 'Error: unable to unable to change ownership/setuid on weston-launch.'; \
+               echo 'To skip this step, re-run ./configure using --disable-setuid-install'; \
+               false; \
+       fi
 endif
 
 endif # BUILD_WESTON_LAUNCH