ext2: Use kmemdup rather than duplicating its implementation

kmemdup is introduced to duplicate a region of memory in a neat way.
Rather than kmalloc/kzalloc + memset, which the programmer needs to
write the size twice (sometimes lead to mistakes), kmemdup improves
readability, leads to smaller code and also reduce the chances of mistakes.
Suggestion to use kmemdup rather than using kmalloc/kzalloc + memset.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Link: https://lore.kernel.org/r/20190703131727.25735-1-huangfq.daxian@gmail.com
Signed-off-by: Jan Kara <jack@suse.cz>

diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
index 839e71e78673fd6846b2e4515532de6edf6d2d57..79369c13cc55780d06ef382940e4b2c029212a38 100644 (file)
--- a/fs/ext2/xattr.c
+++ b/fs/ext2/xattr.c
@@ -532,11 +532,10 @@ bad_block:
 
                        unlock_buffer(bh);
                        ea_bdebug(bh, "cloning");
-                       header = kmalloc(bh->b_size, GFP_KERNEL);
+                       header = kmemdup(HDR(bh), bh->b_size, GFP_KERNEL);
                        error = -ENOMEM;
                        if (header == NULL)
                                goto cleanup;
-                       memcpy(header, HDR(bh), bh->b_size);
                        header->h_refcount = cpu_to_le32(1);
 
                        offset = (char *)here - bh->b_data;