SUNRPC: Clean up xdr_commit_encode()
authorChuck Lever <chuck.lever@oracle.com>
Tue, 7 Jun 2022 20:48:05 +0000 (16:48 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Wed, 8 Jun 2022 16:39:37 +0000 (12:39 -0400)
Both the kvec::iov_len field and the third parameter of memcpy() and
memmove() are size_t. There's no reason for the implicit conversion
from size_t to int and back. Change the type of @shift to make the
code easier to read and understand.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: NeilBrown <neilb@suse.de>
Reviewed-by: J. Bruce Fields <bfields@fieldses.org>
net/sunrpc/xdr.c

index 1ad8b4e..3c18204 100644 (file)
@@ -933,7 +933,7 @@ EXPORT_SYMBOL_GPL(xdr_init_encode);
  */
 void __xdr_commit_encode(struct xdr_stream *xdr)
 {
-       int shift = xdr->scratch.iov_len;
+       size_t shift = xdr->scratch.iov_len;
        void *page;
 
        page = page_address(*xdr->page_ptr);