Resolve svace error

Change-Id: Ifc2355734ae44075ade77a9f6c6aa4c290e8b61d
Signed-off-by: Prakash <prakashc.p@samsung.com>

diff --git a/src/data/ge-data.c b/src/data/ge-data.c
index fcda482cc6355c33437efbfbaf7317e5aea03161..1df76c723a12b2bff074c2f7de3e64be11a184ec 100644 (file)
--- a/src/data/ge-data.c
+++ b/src/data/ge-data.c
@@ -94,12 +94,14 @@ int _ge_data_get_sel_paths(ge_ugdata *ugd, char **filepath, char ***filepath_arr
        Eina_List *l = NULL;
 
        EINA_LIST_FOREACH(ugd->selected_elist, l, sit) {
-               g_string_append(selected_path, sit->file_url);
-               g_string_append_c(selected_path, ';');
-               path_list = eina_list_append(path_list, sit);
-               _cnt++;
-               sit = NULL;
-       }
+               if (sit) {
+                       g_string_append(selected_path, sit->file_url);
+                               g_string_append_c(selected_path, ';');
+                               path_list = eina_list_append(path_list, sit);
+                               _cnt++;
+                               sit = NULL;
+                       }
+               }
 
        /* copy path from path_list to path_array */
        int idx = 0;

diff --git a/src/gallery-efl.c b/src/gallery-efl.c
index 3b4f170bf33777ee714f536063e1c3676d2993d8..1a6d0712019f6ecf535500fd8391c95140f61c38 100644 (file)
--- a/src/gallery-efl.c
+++ b/src/gallery-efl.c
@@ -387,47 +387,53 @@ static int _ge_parse_param(ge_ugdata *ugd, app_control_h service)
                        return -1;
                }
        }
-       ge_dbg("launch-type [%s]", launch_type);
+       if (launch_type) {
+               ge_dbg("launch-type [%s]", launch_type);
+               if (!strcasecmp(launch_type, GE_LAUNCH_SELECT_ALBUM)) {
+                       ugd->album_select_mode = GE_ALBUM_SELECT_T_ONE;
+               } else if (!strcasecmp(launch_type, GE_LAUNCH_SELECT_SETAS)) {
+                       ugd->file_select_mode = GE_FILE_SELECT_T_SETAS;
+                       __ge_parse_param_setas(ugd, service);
+                       /* Checkme: Only image type is offered in SETAS  case */
+                       ugd->file_type_mode = GE_FILE_T_IMAGE;
+               } else {
+                       if (!strcasecmp(launch_type, GE_LAUNCH_SELECT_ONE)) {
+                               ugd->file_select_mode = GE_FILE_SELECT_T_ONE;
+                       } else if (!strcasecmp(launch_type, GE_LAUNCH_SELECT_MULTIPLE)) {
+                               ugd->file_select_mode = GE_FILE_SELECT_T_MULTIPLE;
+                               ugd->b_multifile = true;
+                       } else if (!strcasecmp(launch_type, GE_LAUNCH_SELECT_IMFT)) {
+                               ugd->file_select_mode = GE_FILE_SELECT_T_IMFT;
+                               ugd->b_multifile = true;
 
-       if (!strcasecmp(launch_type, GE_LAUNCH_SELECT_ALBUM)) {
-               ugd->album_select_mode = GE_ALBUM_SELECT_T_ONE;
-       } else if (!strcasecmp(launch_type, GE_LAUNCH_SELECT_SETAS)) {
-               ugd->file_select_mode = GE_FILE_SELECT_T_SETAS;
-               __ge_parse_param_setas(ugd, service);
-               /* Checkme: Only image type is offered in SETAS  case */
-               ugd->file_type_mode = GE_FILE_T_IMAGE;
-       } else {
-               if (!strcasecmp(launch_type, GE_LAUNCH_SELECT_ONE)) {
-                       ugd->file_select_mode = GE_FILE_SELECT_T_ONE;
-               } else if (!strcasecmp(launch_type, GE_LAUNCH_SELECT_MULTIPLE)) {
-                       ugd->file_select_mode = GE_FILE_SELECT_T_MULTIPLE;
-                       ugd->b_multifile = true;
-               } else if (!strcasecmp(launch_type, GE_LAUNCH_SELECT_IMFT)) {
-                       ugd->file_select_mode = GE_FILE_SELECT_T_IMFT;
-                       ugd->b_multifile = true;
-
-                       char *contact_id = NULL;
-                       app_control_get_extra_data(service, "contact", &contact_id);
-                       if (contact_id) {
-                               ugd->file_select_contact_id = atoi(contact_id);
-                               GE_FREE(contact_id);
+                               char *contact_id = NULL;
+                               app_control_get_extra_data(service, "contact", &contact_id);
+                               if (contact_id) {
+                                       ugd->file_select_contact_id = atoi(contact_id);
+                                       GE_FREE(contact_id);
+                               } else {
+                                       ugd->file_select_mode = GE_FILE_SELECT_T_NONE;
+                                       ugd->file_select_contact_id = -1;
+                                       ge_dbg("Invalid args");
+                                       GE_FREEIF(operation);
+                                       GE_FREEIF(launch_type);
+                                       return -1;
+                               }
+
+                               ge_sdbg("contact_id: %d", ugd->file_select_contact_id);
+                       } else if (!strcasecmp(launch_type, GE_LAUNCH_SELECT_SLIDESHOW)) {
+                               __ge_parse_param_slideshow(ugd, service);
                        } else {
-                               ugd->file_select_mode = GE_FILE_SELECT_T_NONE;
-                               ugd->file_select_contact_id = -1;
-                               ge_dbg("Invalid args");
-                               GE_FREEIF(operation);
-                               GE_FREE(launch_type);
-                               return -1;
+                               ge_dbgE("Wrong launch type!");
                        }
 
-                       ge_sdbg("contact_id: %d", ugd->file_select_contact_id);
-               } else if (!strcasecmp(launch_type, GE_LAUNCH_SELECT_SLIDESHOW)) {
-                       __ge_parse_param_slideshow(ugd, service);
-               } else {
-                       ge_dbgE("Wrong launch type!");
+                       __ge_parse_param_file(ugd, service);
                }
-
-               __ge_parse_param_file(ugd, service);
+       } else {
+               //using default values
+               ge_dbg("Set launch-type to default");
+               ugd->album_select_mode = GE_ALBUM_SELECT_T_ONE;
+               ugd->b_multifile = false;
        }
 
        ugd->max_count = -1;
@@ -453,7 +459,7 @@ static int _ge_parse_param(ge_ugdata *ugd, app_control_h service)
        }
 
        GE_FREEIF(operation);
-       GE_FREE(launch_type);
+       GE_FREEIF(launch_type);
        return 0;
 }
 
@@ -682,7 +688,9 @@ static void _ge_message(ui_gadget_h ug, app_control_h msg, app_control_h service
                                ge_item *gitem = NULL;
 
                                EINA_LIST_FOREACH(ugd->thumbs_d->medias_elist, l, gitem) {
-                                       gitem->checked = false;
+                                       if (gitem) {
+                                               gitem->checked = false;
+                                       }
                                }
 
                                if (ugd->selected_elist) {

diff --git a/src/view/ge-albums.c b/src/view/ge-albums.c
index 0179234c07cccab47af1aa0dff51de223273727e..da2fe96f8a0664b37095a16cc6fe86680a242a58 100644 (file)
--- a/src/view/ge-albums.c
+++ b/src/view/ge-albums.c
@@ -866,7 +866,9 @@ static Eina_Bool __ge_main_back_cb(void *data, Elm_Object_Item *it)
        }
 
        EINA_LIST_FOREACH(ugd->thumbs_d->medias_elist, l, gitem) {
-               gitem->checked = false;
+               if (gitem) {
+                       gitem->checked = false;
+               }
        }
 
        ugd->selected_elist = eina_list_free(ugd->selected_elist);
@@ -1026,7 +1028,7 @@ __ge_check_state_changed_cb(void *data, Evas_Object *obj, void *ei)
        } else {
                ge_sdbg("remove Path: %s", sit->file_url);
                EINA_LIST_FOREACH(ugd->selected_elist, l, sit1) {
-                       if (!strcmp(sit->file_url, sit1->file_url)) {
+                       if (sit1 && !strcmp(sit->file_url, sit1->file_url)) {
                                ugd->selected_elist = eina_list_remove(ugd->selected_elist, sit1);
                                _ge_data_util_free_sel_item(sit1);
                        }
@@ -1366,7 +1368,7 @@ __ge_gengrid_item_sel_cb(void *data, Evas_Object *obj, void *ei)
 #endif
                        ge_sdbg("remove Path: %s", sit->file_url);
                        EINA_LIST_FOREACH(ugd->selected_elist, l, sit1) {
-                               if (!strcmp(sit->file_url, sit1->file_url)) {
+                               if (sit1 && !strcmp(sit->file_url, sit1->file_url)) {
                                        ugd->selected_elist = eina_list_remove(ugd->selected_elist, sit1);
                                        _ge_data_util_free_sel_item(sit1);
                                }
@@ -1425,7 +1427,9 @@ __ge_cancel_cb(void *data, Evas_Object *obj, void *ei)
        }
 
        EINA_LIST_FOREACH(app_data->thumbs_d->medias_elist, l, gitem) {
-               gitem->checked = false;
+               if (gitem) {
+                       gitem->checked = false;
+               }
        }
 
        app_data->selected_elist = eina_list_free(app_data->selected_elist);
@@ -1508,7 +1512,7 @@ ge_update_gengrid(ge_ugdata *ugd)
 
                        if (ugd->selected_elist) {
                                EINA_LIST_FOREACH(ugd->selected_elist, l, sit) {
-                                       if (strcmp(sit->file_url, gitem->item->file_url) == 0) {
+                                       if (sit && strcmp(sit->file_url, gitem->item->file_url) == 0) {
                                                gitem->checked = true;
                                                ugd->thumbs_d->tot_selected++;
                                        }