usb: host: xhci-hub: fix extra endianness conversion
authorRuslan Bilovol <ruslan.bilovol@gmail.com>
Sun, 7 Jul 2019 12:17:19 +0000 (15:17 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:24:28 +0000 (10:24 +0100)
[ Upstream commit 6269e4c76eacabaea0d0099200ae1a455768d208 ]

Don't do extra cpu_to_le32 conversion for
put_unaligned_le32 because it is already implemented
in this function.

Fixes sparse error:
xhci-hub.c:1152:44: warning: incorrect type in argument 1 (different base types)
xhci-hub.c:1152:44:    expected unsigned int [usertype] val
xhci-hub.c:1152:44:    got restricted __le32 [usertype]

Fixes: 395f540 "xhci: support new USB 3.1 hub request to get extended port status"
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
Link: https://lore.kernel.org/r/1562501839-26522-1-git-send-email-ruslan.bilovol@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/host/xhci-hub.c

index 5cf5f3d..04d36fa 100644 (file)
@@ -989,7 +989,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
                        }
                        port_li = readl(port_array[wIndex] + PORTLI);
                        status = xhci_get_ext_port_status(temp, port_li);
-                       put_unaligned_le32(cpu_to_le32(status), &buf[4]);
+                       put_unaligned_le32(status, &buf[4]);
                }
                break;
        case SetPortFeature: