driver core: Change delimiter in devlink device's name to "--"
authorSaravana Kannan <saravanak@google.com>
Fri, 24 Jul 2020 18:05:22 +0000 (11:05 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Jul 2020 18:55:25 +0000 (20:55 +0200)
The devlink device name is of the form "supplier:consumer". But ":" is
fairly common in device names and makes it visually hard to distinguish
supplier and consumer. So, replace it with "--" to make it easier.

Signed-off-by: Saravana Kannan <saravanak@google.com>
Link: https://lore.kernel.org/r/20200724180523.1393383-1-saravanak@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Documentation/ABI/testing/sysfs-class-devlink
drivers/base/core.c

index 3a24973..64791b6 100644 (file)
@@ -4,7 +4,7 @@ Contact:        Saravana Kannan <saravanak@google.com>
 Description:
                Provide a place in sysfs for the device link objects in the
                kernel at any given time.  The name of a device link directory,
-               denoted as ... above, is of the form <supplier>:<consumer>
+               denoted as ... above, is of the form <supplier>--<consumer>
                where <supplier> is the supplier device name and <consumer> is
                the consumer device name.
 
index b6e8b0b..4d05868 100644 (file)
@@ -623,7 +623,7 @@ struct device_link *device_link_add(struct device *consumer,
 
        link->link_dev.class = &devlink_class;
        device_set_pm_not_required(&link->link_dev);
-       dev_set_name(&link->link_dev, "%s:%s",
+       dev_set_name(&link->link_dev, "%s--%s",
                     dev_name(supplier), dev_name(consumer));
        if (device_register(&link->link_dev)) {
                put_device(consumer);