devtmpfs: add debug info to handle()
authorLonglong Xia <xialonglong1@huawei.com>
Fri, 10 Feb 2023 09:54:43 +0000 (09:54 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Feb 2023 10:26:36 +0000 (11:26 +0100)
Because handle() is the core function for processing devtmpfs requests,
Let's add some debug info in handle() to help users know why failed.

Signed-off-by: Longlong Xia <xialonglong1@huawei.com>
Link: https://lore.kernel.org/r/20230210095444.4067307-3-xialonglong1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/devtmpfs.c

index 95ebc18..f273bcc 100644 (file)
@@ -389,10 +389,18 @@ static __initdata DECLARE_COMPLETION(setup_done);
 static int handle(const char *name, umode_t mode, kuid_t uid, kgid_t gid,
                  struct device *dev)
 {
+       int ret;
+
        if (mode)
-               return handle_create(name, mode, uid, gid, dev);
+               ret = handle_create(name, mode, uid, gid, dev);
        else
-               return handle_remove(name, dev);
+               ret = handle_remove(name, dev);
+
+       if (ret)
+               dev_err(dev, "failed to %s %s, ret = %d\n",
+                       mode ? "create" : "remove", name, ret);
+
+       return ret;
 }
 
 static void __noreturn devtmpfs_work_loop(void)