platform/x86: dell-laptop: Handle return error form dell_get_intensity.
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Thu, 9 Mar 2017 05:49:56 +0000 (11:19 +0530)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 28 Apr 2017 18:51:26 +0000 (21:51 +0300)
Here, This patch is to handle a return error from dell_get_intensity.
This change is done using Coccinelle.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/dell-laptop.c

index 47fe626..296cb96 100644 (file)
@@ -2151,11 +2151,17 @@ static int __init dell_init(void)
 
                dell_backlight_device->props.brightness =
                        dell_get_intensity(dell_backlight_device);
+               if (dell_backlight_device->props.brightness < 0) {
+                       ret = dell_backlight_device->props.brightness;
+                       goto fail_get_brightness;
+               }
                backlight_update_status(dell_backlight_device);
        }
 
        return 0;
 
+fail_get_brightness:
+       backlight_device_unregister(dell_backlight_device);
 fail_backlight:
        dell_cleanup_rfkill();
 fail_rfkill: