pass: Remove duplicate log when failed to read configuration file

This patch just removes the duplicate log message. The same meaning logs
makes the confusion.

[Before]
config-parser.c: config_parse(66) > Failed to open file /etc/pass/pass.conf
config-parser.c: config_parse(126) > Failed to read /etc/pass/pass.conf:0!
pass-parser.c: pass_parse_resource(637) > cannot parse /etc/pass/pass.conf
pass.c: pass_init_done(226) > cannot parse /etc/pass/pass.conf
config-parser.c: config_parse(66) > Failed to open file /etc/pass/pass-pmqos.conf
config-parser.c: config_parse(126) > Failed to read /etc/pass/pass-pmqos.conf:0!
pmqos-parser.c: pmqos_get_scenario(156) > failed to load conficuration file(/etc/pass/pass-pmqos.conf) : -5
pmqos.c: pmqos_init_done(497) > failed to load configuration file(/etc/pass/pass-pmqos.conf)

[After]
pass.c: pass_init_done(226) > cannot parse /etc/pass/pass.conf
pmqos.c: pmqos_init_done(497) > failed to load configuration file(/etc/pass/pass-pmqos.conf)

Change-Id: I5b40c199811abf3db9b51d2801e523f8eedaf8a6
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

diff --git a/src/core/config-parser.c b/src/core/config-parser.c
index fe0df234df03dfe29bb44b22b2afd69425bd10eb..f1bc6f99cf7b1529a223686356d517e97be0eb10 100644 (file)
--- a/src/core/config-parser.c
+++ b/src/core/config-parser.c
@@ -63,7 +63,6 @@ int config_parse(const char *file_name, int cb(struct parse_result *result,
        /* open conf file */
        f = fopen(file_name, "r");
        if (!f) {
-               _E("Failed to open file %s", file_name);
                ret = -EIO;
                goto error;
        }
@@ -123,6 +122,5 @@ int config_parse(const char *file_name, int cb(struct parse_result *result,
 error:
        if (f)
                fclose(f);
-       _E("Failed to read %s:%d!", file_name, lineno);
        return ret;
 }

diff --git a/src/pass/pass-parser.c b/src/pass/pass-parser.c
index 206f4289955731bf74535ba1060d9b426467a74c..0051d9424f3903a3e40a1f41109d025a81d2d036 100644 (file)
--- a/src/pass/pass-parser.c
+++ b/src/pass/pass-parser.c
@@ -630,13 +630,5 @@ static int pass_resource_config(struct parse_result *result, void *user_data)
 
 int pass_parse_resource(struct pass *pass, char *pass_conf_path)
 {
-       int ret;
-
-       ret = config_parse(pass_conf_path, pass_resource_config, pass);
-       if (ret < 0) {
-               _E("cannot parse %s\n", pass_conf_path);
-               return -EINVAL;
-       }
-
-       return 0;
+       return config_parse(pass_conf_path, pass_resource_config, pass);
 }

diff --git a/src/pmqos/pmqos-parser.c b/src/pmqos/pmqos-parser.c
index 9efea8993d55b6143c560807ace6d2d45bec93e0..6f5a13bce6f36da7def487833a74be87f6420ef1 100644 (file)
--- a/src/pmqos/pmqos-parser.c
+++ b/src/pmqos/pmqos-parser.c
@@ -153,7 +153,6 @@ int pmqos_get_scenario(const char *path, struct pmqos_scenario *scenarios)
        /* get configuration file */
        ret = config_parse(path, pmqos_load_config, scenarios);
        if (ret < 0) {
-               _E("failed to load conficuration file(%s) : %d", path, ret);
                pmqos_put_scenario(scenarios);
                return ret;
        }