spi: fsl-dspi: Use dev_err_probe() in dspi_request_dma()
authorMinjie Du <duminjie@vivo.com>
Tue, 25 Jul 2023 03:50:37 +0000 (11:50 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 25 Jul 2023 11:14:30 +0000 (12:14 +0100)
It is possible for dma_request_chan() to return EPROBE_DEFER, which means
dev is not ready yet.
At this point dev_err() will have no output.

Signed-off-by: Minjie Du <duminjie@vivo.com>
Link: https://lore.kernel.org/r/20230725035038.1702-1-duminjie@vivo.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-dspi.c

index ca41c8a..150d2eb 100644 (file)
@@ -503,15 +503,14 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr)
 
        dma->chan_rx = dma_request_chan(dev, "rx");
        if (IS_ERR(dma->chan_rx)) {
-               dev_err(dev, "rx dma channel not available\n");
-               ret = PTR_ERR(dma->chan_rx);
-               return ret;
+               return dev_err_probe(dev, PTR_ERR(dma->chan_rx),
+                       "rx dma channel not available\n");
        }
 
        dma->chan_tx = dma_request_chan(dev, "tx");
        if (IS_ERR(dma->chan_tx)) {
-               dev_err(dev, "tx dma channel not available\n");
                ret = PTR_ERR(dma->chan_tx);
+               dev_err_probe(dev, ret, "tx dma channel not available\n");
                goto err_tx_channel;
        }