drm/vc4: hvs: More logging for dlist generation
authorMaxime Ripard <maxime@cerno.tech>
Wed, 22 Mar 2023 08:51:51 +0000 (09:51 +0100)
committerDom Cobley <popcornmix@gmail.com>
Mon, 19 Feb 2024 11:34:53 +0000 (11:34 +0000)
DLIST generation can get pretty tricky and there's not a lot of debug in
the driver to help. Let's add a few more to track the generated DLIST
size.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
drivers/gpu/drm/vc4/vc4_hvs.c

index b3634cd..2b1147f 100644 (file)
@@ -826,11 +826,22 @@ int vc4_hvs_atomic_check(struct drm_crtc *crtc, struct drm_atomic_state *state)
        if (hweight32(crtc_state->connector_mask) > 1)
                return -EINVAL;
 
-       drm_atomic_crtc_state_for_each_plane_state(plane, plane_state, crtc_state)
-               dlist_count += vc4_plane_dlist_size(plane_state);
+       drm_atomic_crtc_state_for_each_plane_state(plane, plane_state, crtc_state) {
+               u32 plane_dlist_count = vc4_plane_dlist_size(plane_state);
+
+               drm_dbg_driver(dev, "[CRTC:%d:%s] Found [PLANE:%d:%s] with DLIST size: %u\n",
+                              crtc->base.id, crtc->name,
+                              plane->base.id, plane->name,
+                              plane_dlist_count);
+
+               dlist_count += plane_dlist_count;
+       }
 
        dlist_count++; /* Account for SCALER_CTL0_END. */
 
+       drm_dbg_driver(dev, "[CRTC:%d:%s] Allocating DLIST block with size: %u\n",
+                      crtc->base.id, crtc->name, dlist_count);
+
        alloc = vc4_hvs_alloc_dlist_entry(vc4->hvs, vc4_state->assigned_channel, dlist_count);
        if (IS_ERR(alloc))
                return PTR_ERR(alloc);