hwmon: (pmbus) Simplify the calculation of variables
authorJiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Tue, 26 Jan 2021 06:21:40 +0000 (14:21 +0800)
committerGuenter Roeck <linux@roeck-us.net>
Thu, 28 Jan 2021 01:55:46 +0000 (17:55 -0800)
Fix the following coccicheck warnings:

./drivers/hwmon/pmbus/pmbus_core.c:1265:24-26: WARNING !A || A && B is
equivalent to !A || B.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Link: https://lore.kernel.org/r/1611642100-29937-1-git-send-email-abaci-bugfix@linux.alibaba.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/pmbus/pmbus_core.c

index 906c9fe..1cf7d9e 100644 (file)
@@ -1262,7 +1262,7 @@ static int pmbus_add_sensor_attrs_one(struct i2c_client *client,
                 * which global bit is set) for this page is accessible.
                 */
                if (!ret && attr->gbit &&
-                   (!upper || (upper && data->has_status_word)) &&
+                   (!upper || data->has_status_word) &&
                    pmbus_check_status_register(client, page)) {
                        ret = pmbus_add_boolean(data, name, "alarm", index,
                                                NULL, NULL,