selftests/net: fix typo in tcp_mmap
authorEric Dumazet <edumazet@google.com>
Wed, 5 Apr 2023 07:15:56 +0000 (07:15 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 6 Apr 2023 11:19:25 +0000 (13:19 +0200)
kernel test robot reported the following warning:

All warnings (new ones prefixed by >>):

   tcp_mmap.c: In function 'child_thread':
>> tcp_mmap.c:211:61: warning: 'lu' may be used uninitialized in this function [-Wmaybe-uninitialized]
     211 |                         zc.length = min(chunk_size, FILE_SZ - lu);

We want to read FILE_SZ bytes, so the correct expression
should be (FILE_SZ - total)

Fixes: 5c5945dc695c ("selftests/net: Add SHA256 computation over data sent in tcp_mmap")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304042104.UFIuevBp-lkp@intel.com/
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Xiaoyan Li <lixiaoyan@google.com>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://lore.kernel.org/r/20230405071556.1019623-1-edumazet@google.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
tools/testing/selftests/net/tcp_mmap.c

index 607cc9a..6e59b14 100644 (file)
@@ -208,7 +208,7 @@ void *child_thread(void *arg)
 
                        memset(&zc, 0, sizeof(zc));
                        zc.address = (__u64)((unsigned long)addr);
-                       zc.length = min(chunk_size, FILE_SZ - lu);
+                       zc.length = min(chunk_size, FILE_SZ - total);
 
                        res = getsockopt(fd, IPPROTO_TCP, TCP_ZEROCOPY_RECEIVE,
                                         &zc, &zc_len);