[SCSI] target: Fix volume size misreporting for volumes > 2TB
authorNicholas Bellinger <nab@linux-iscsi.org>
Wed, 2 Mar 2011 23:52:51 +0000 (15:52 -0800)
committerJames Bottomley <James.Bottomley@suse.de>
Mon, 14 Mar 2011 23:31:08 +0000 (18:31 -0500)
the target infrastructure fails to send the correct conventional size
to READ_CAPACITY that force a retry with READ_CAPACITY_16, which reads
the capacity for devices > 2TB.  Fix by adding the correct return to
trigger RC(16).

Reported-by: Ben Jarvis <bjarvismn@gmail.com>
Signed-off-by: Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
Cc: stable@kernel.org
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/target/target_core_cdb.c

index 366080b..7f19c8b 100644 (file)
@@ -667,7 +667,13 @@ target_emulate_readcapacity(struct se_cmd *cmd)
 {
        struct se_device *dev = SE_DEV(cmd);
        unsigned char *buf = cmd->t_task->t_task_buf;
-       u32 blocks = dev->transport->get_blocks(dev);
+       unsigned long long blocks_long = dev->transport->get_blocks(dev);
+       u32 blocks;
+
+       if (blocks_long >= 0x00000000ffffffff)
+               blocks = 0xffffffff;
+       else
+               blocks = (u32)blocks_long;
 
        buf[0] = (blocks >> 24) & 0xff;
        buf[1] = (blocks >> 16) & 0xff;