qla1280: Remove redundant NULL check before release_firmware() call

release_firmware() checks for NULL pointers internally so checking
before calling the function is redundant.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 6c6486f..538230b 100644 (file)
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -4473,17 +4473,14 @@ qla1280_exit(void)
        pci_unregister_driver(&qla1280_pci_driver);
        /* release any allocated firmware images */
        for (i = 0; i < QL_NUM_FW_IMAGES; i++) {
-               if (qla1280_fw_tbl[i].fw) {
-                       release_firmware(qla1280_fw_tbl[i].fw);
-                       qla1280_fw_tbl[i].fw = NULL;
-               }
+               release_firmware(qla1280_fw_tbl[i].fw);
+               qla1280_fw_tbl[i].fw = NULL;
        }
 }
 
 module_init(qla1280_init);
 module_exit(qla1280_exit);
 
-
 MODULE_AUTHOR("Qlogic & Jes Sorensen");
 MODULE_DESCRIPTION("Qlogic ISP SCSI (qla1x80/qla1x160) driver");
 MODULE_LICENSE("GPL");