[lld-macho] Fix BUILD_SHARED_LIBS build
authorAlex Richardson <Alexander.Richardson@cl.cam.ac.uk>
Thu, 3 Jun 2021 18:58:43 +0000 (19:58 +0100)
committerAlex Richardson <Alexander.Richardson@cl.cam.ac.uk>
Thu, 3 Jun 2021 18:58:43 +0000 (19:58 +0100)
ca6751043d8899b12baeb48621e61fb352cfee09 added a dependency on XAR (at
least for the shared libs build), so without this change we get the
following linker error:

Undefined symbols for architecture x86_64:
  "_xar_close", referenced from:
      lld::macho::BitcodeBundleSection::finalize() in SyntheticSections.cpp.o

Reviewed By: #lld-macho, int3, thakis

Differential Revision: https://reviews.llvm.org/D100999

lld/MachO/CMakeLists.txt
lld/tools/lld/CMakeLists.txt

index a805e17..61ac878 100644 (file)
@@ -55,3 +55,7 @@ add_lld_library(lldMachO2
   MachOOptionsTableGen
   ${tablegen_deps}
   )
+
+if(LLVM_HAVE_LIBXAR)
+  target_link_libraries(lldMachO2 PRIVATE ${XAR_LIB})
+endif()
index 738f484..e77b216 100644 (file)
@@ -20,10 +20,6 @@ target_link_libraries(lld
   lldWasm
   )
 
-if(LLVM_HAVE_LIBXAR)
-  target_link_libraries(lld PRIVATE ${XAR_LIB})
-endif()
-
 install(TARGETS lld
   RUNTIME DESTINATION bin)