pds_core: fix memory leak in pdsc_debugfs_add_qcq()

[ Upstream commit 8b82f656826c741d032490b089a5638c33f2c91d ]

The memory allocated for intr_ctrl_regset, which is passed to
debugfs_create_regset32() may not be cleaned up when the driver is
removed. Fix that by using device managed allocation for it.

Fixes: 45d76f492938 ("pds_core: set up device and adminq")
Signed-off-by: Abdun Nihaal <abdun.nihaal@gmail.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
Link: https://patch.msgid.link/20250409054450.48606-1-abdun.nihaal@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/ethernet/amd/pds_core/debugfs.c b/drivers/net/ethernet/amd/pds_core/debugfs.c
index 4e8579ca1c8c71bd89659f041f3613113af16141..51f3f73a839a9d1b31f4949eefd690da61e87835 100644 (file)
--- a/drivers/net/ethernet/amd/pds_core/debugfs.c
+++ b/drivers/net/ethernet/amd/pds_core/debugfs.c
@@ -154,8 +154,9 @@ void pdsc_debugfs_add_qcq(struct pdsc *pdsc, struct pdsc_qcq *qcq)
                debugfs_create_u32("index", 0400, intr_dentry, &intr->index);
                debugfs_create_u32("vector", 0400, intr_dentry, &intr->vector);
 
-               intr_ctrl_regset = kzalloc(sizeof(*intr_ctrl_regset),
-                                          GFP_KERNEL);
+               intr_ctrl_regset = devm_kzalloc(pdsc->dev,
+                                               sizeof(*intr_ctrl_regset),
+                                               GFP_KERNEL);
                if (!intr_ctrl_regset)
                        return;
                intr_ctrl_regset->regs = intr_ctrl_regs;