watchdog: starfive: Fix the probe return error if PM and early_enable are both disabled
authorXingyu Wu <xingyu.wu@starfivetech.com>
Wed, 26 Apr 2023 03:12:16 +0000 (11:12 +0800)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sat, 29 Apr 2023 06:08:40 +0000 (08:08 +0200)
When the starfive watchdog driver uses 'pm_runtime_put_sync()' as probe
return value at last and 'early_enable' is disabled, it could return the
error '-ENOSYS' if the CONFIG_PM is disabled, but the driver should works
normally.

Drop the 'return' and keep the 'pm_runtime_put_sync()', but do not use it
as the return value.

Fixes: db728ea9c7be ("drivers: watchdog: Add StarFive Watchdog driver")
Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230426031216.37981-1-xingyu.wu@starfivetech.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/starfive-wdt.c

index 1995cce..8f37890 100644 (file)
@@ -492,7 +492,7 @@ static int starfive_wdt_probe(struct platform_device *pdev)
                goto err_exit;
 
        if (!early_enable)
-               return pm_runtime_put_sync(&pdev->dev);
+               pm_runtime_put_sync(&pdev->dev);
 
        return 0;