media: tw5864: Simplify 'tw5864_finidev()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 16 Oct 2021 08:40:29 +0000 (09:40 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 15 Nov 2021 08:12:01 +0000 (08:12 +0000)
Some resources are allocated with 'pci_request_regions()', so use
'pci_release_regions()' to free them, instead of a verbose
'release_mem_region()'.

There is no point in calling 'devm_kfree()'. The corresponding resource is
managed, so it will be fried automatically.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/pci/tw5864/tw5864-core.c

index 23d3cae..fee3b77 100644 (file)
@@ -333,11 +333,9 @@ static void tw5864_finidev(struct pci_dev *pci_dev)
 
        /* release resources */
        iounmap(dev->mmio);
-       release_mem_region(pci_resource_start(pci_dev, 0),
-                          pci_resource_len(pci_dev, 0));
+       pci_release_regions(pci_dev);
 
        v4l2_device_unregister(&dev->v4l2_dev);
-       devm_kfree(&pci_dev->dev, dev);
 }
 
 static struct pci_driver tw5864_pci_driver = {