mmc: bcm2835: Remove local_irq_{save,restore}() around k[un]map_atomic()
authorAdrian Hunter <adrian.hunter@intel.com>
Wed, 5 Oct 2022 10:19:41 +0000 (13:19 +0300)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 7 Dec 2022 12:22:32 +0000 (13:22 +0100)
A long time ago the kmap_atomic API required a slot to be provided which
risked the possibility that other code might use the same slot at the
same time. Disabling interrupts prevented the possibility of an interrupt
handler doing that. However, that went away with
commit 3e4d3af501cc ("mm: stack based kmap_atomic()").

Unfortunately, that unnecessary pattern of code has been copied since
and persists in bcm2385.c.

Remove it.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20221005101951.3165-5-adrian.hunter@intel.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/bcm2835.c

index 641ab4f42125bf6e2bbe39656109b548d2eeb83b..49acbfa87ab83a8e2484fd367cacf185d4e1e7f4 100644 (file)
@@ -1068,7 +1068,6 @@ static void bcm2835_dma_complete_work(struct work_struct *work)
        }
 
        if (host->drain_words) {
-               unsigned long flags;
                void *page;
                u32 *buf;
 
@@ -1076,7 +1075,6 @@ static void bcm2835_dma_complete_work(struct work_struct *work)
                        host->drain_page += host->drain_offset >> PAGE_SHIFT;
                        host->drain_offset &= ~PAGE_MASK;
                }
-               local_irq_save(flags);
                page = kmap_atomic(host->drain_page);
                buf = page + host->drain_offset;
 
@@ -1089,7 +1087,6 @@ static void bcm2835_dma_complete_work(struct work_struct *work)
                }
 
                kunmap_atomic(page);
-               local_irq_restore(flags);
        }
 
        bcm2835_finish_data(host);