projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d1dbff1
)
driver core: location: Free struct acpi_pld_info *pld before return false
author
Hanjun Guo
<guohanjun@huawei.com>
Tue, 22 Nov 2022 07:37:28 +0000
(15:37 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:33:33 +0000
(09:33 +0100)
[ Upstream commit
0d150f967e8410e1e6712484543eec709356a65d
]
struct acpi_pld_info *pld should be freed before the return of allocation
failure, to prevent memory leak, add the ACPI_FREE() to fix it.
Fixes:
bc443c31def5
("driver core: location: Check for allocations failure")
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
Link:
https://lore.kernel.org/r/1669102648-11517-1-git-send-email-guohanjun@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/base/physical_location.c
patch
|
blob
|
history
diff --git
a/drivers/base/physical_location.c
b/drivers/base/physical_location.c
index
87af641
..
951819e
100644
(file)
--- a/
drivers/base/physical_location.c
+++ b/
drivers/base/physical_location.c
@@
-24,8
+24,11
@@
bool dev_add_physical_location(struct device *dev)
dev->physical_location =
kzalloc(sizeof(*dev->physical_location), GFP_KERNEL);
- if (!dev->physical_location)
+ if (!dev->physical_location) {
+ ACPI_FREE(pld);
return false;
+ }
+
dev->physical_location->panel = pld->panel;
dev->physical_location->vertical_position = pld->vertical_position;
dev->physical_location->horizontal_position = pld->horizontal_position;