scsi: target: tcmu: Replace zero-length array with flexible-array member
authorGustavo A. R. Silva <gustavoars@kernel.org>
Mon, 31 Aug 2020 13:25:42 +0000 (08:25 -0500)
committerGustavo A. R. Silva <gustavoars@kernel.org>
Thu, 29 Oct 2020 22:22:59 +0000 (17:22 -0500)
There is a regular need in the kernel to provide a way to declare having a
dynamically sized set of trailing elements in a structure. Kernel code should
always use “flexible array members”[1] for these cases. The older style of
one-element or zero-length arrays should no longer be used[2].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.9-rc1/process/deprecated.html#zero-length-and-one-element-arrays

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
drivers/target/target_core_user.c

index ea84d08747df3749f878867228b5559c7c164674..590e6d072228109fbec0c37ea73662de7b5aa9a3 100644 (file)
@@ -194,7 +194,7 @@ struct tcmu_tmr {
 
        uint8_t tmr_type;
        uint32_t tmr_cmd_cnt;
-       int16_t tmr_cmd_ids[0];
+       int16_t tmr_cmd_ids[];
 };
 
 /*