ftrace: fix building with SYSCTL=y but DYNAMIC_FTRACE=n
authorLuis Chamberlain <mcgrof@kernel.org>
Thu, 21 Apr 2022 18:38:43 +0000 (11:38 -0700)
committerLuis Chamberlain <mcgrof@kernel.org>
Thu, 21 Apr 2022 20:11:51 +0000 (13:11 -0700)
Ok so hopefully this is the last of it. 0day picked up a build
failure [0] when SYSCTL=y but DYNAMIC_FTRACE=n. This can be fixed
by just declaring an empty routine for the calls moved just
recently.

[0] https://lkml.kernel.org/r/202204161203.6dSlgKJX-lkp@intel.com

Reported-by: kernel test robot <lkp@intel.com>
Fixes: f8b7d2b4c192 ("ftrace: fix building with SYSCTL=n but DYNAMIC_FTRACE=y")
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
kernel/trace/ftrace.c

index d9424fd..1f89039 100644 (file)
@@ -7873,6 +7873,8 @@ int unregister_ftrace_function(struct ftrace_ops *ops)
 EXPORT_SYMBOL_GPL(unregister_ftrace_function);
 
 #ifdef CONFIG_SYSCTL
+
+#ifdef CONFIG_DYNAMIC_FTRACE
 static void ftrace_startup_sysctl(void)
 {
        int command;
@@ -7906,6 +7908,10 @@ static void ftrace_shutdown_sysctl(void)
                ftrace_run_update_code(command);
        }
 }
+#else
+# define ftrace_startup_sysctl()       do { } while (0)
+# define ftrace_shutdown_sysctl()      do { } while (0)
+#endif /* CONFIG_DYNAMIC_FTRACE */
 
 static bool is_permanent_ops_registered(void)
 {