clk: mediatek: clk-mt8195-topckgen: Fix error return code in clk_mt8195_topck_probe()
authorYang Yingliang <yangyingliang@huawei.com>
Sun, 9 Oct 2022 02:50:56 +0000 (10:50 +0800)
committerStephen Boyd <sboyd@kernel.org>
Mon, 17 Oct 2022 21:07:50 +0000 (14:07 -0700)
If devm_clk_hw_register_mux() fails in clk_mt8195_topck_probe(), it should return
error code.

Fixes: deeb2af77cf6 ("clk: mediatek: clk-mt8195-topckgen: Register mfg_ck_fast_ref as generic mux")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221009025056.35311-1-yangyingliang@huawei.com
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/mediatek/clk-mt8195-topckgen.c

index 8cbab5ca2e581dad2a183e6b433736fee8542ee9..1e016329c1d23e19e71aa013a525e7978f4fb757 100644 (file)
@@ -1270,8 +1270,10 @@ static int clk_mt8195_topck_probe(struct platform_device *pdev)
        hw = devm_clk_hw_register_mux(&pdev->dev, "mfg_ck_fast_ref", mfg_fast_parents,
                                      ARRAY_SIZE(mfg_fast_parents), CLK_SET_RATE_PARENT,
                                      (base + 0x250), 8, 1, 0, &mt8195_clk_lock);
-       if (IS_ERR(hw))
+       if (IS_ERR(hw)) {
+               r = PTR_ERR(hw);
                goto unregister_muxes;
+       }
        top_clk_data->hws[CLK_TOP_MFG_CK_FAST_REF] = hw;
 
        r = clk_mt8195_reg_mfg_mux_notifier(&pdev->dev,