mfd: bd70528: Fix hour register mask
authorMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Mon, 20 Jan 2020 13:45:11 +0000 (15:45 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Feb 2020 12:35:52 +0000 (04:35 -0800)
commit 6c883472e1c11cb05561b6dd0c28bb037c2bf2de upstream.

When RTC is used in 24H mode (and it is by this driver) the maximum
hour value is 24 in BCD. This occupies bits [5:0] - which means
correct mask for HOUR register is 0x3f not 0x1f. Fix the mask

Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/mfd/rohm-bd70528.h

index 1013e60..b0109ee 100644 (file)
@@ -317,7 +317,7 @@ enum {
 #define BD70528_MASK_RTC_MINUTE                0x7f
 #define BD70528_MASK_RTC_HOUR_24H      0x80
 #define BD70528_MASK_RTC_HOUR_PM       0x20
-#define BD70528_MASK_RTC_HOUR          0x1f
+#define BD70528_MASK_RTC_HOUR          0x3f
 #define BD70528_MASK_RTC_DAY           0x3f
 #define BD70528_MASK_RTC_WEEK          0x07
 #define BD70528_MASK_RTC_MONTH         0x1f