target/iscsi: Remove dead code from iscsit_process_scsi_cmd()
authorBart Van Assche <bart.vanassche@sandisk.com>
Tue, 23 May 2017 23:48:45 +0000 (16:48 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 7 Jul 2017 06:11:28 +0000 (23:11 -0700)
If an iSCSI command is rejected before iscsit_process_scsi_cmd()
is called, .reject_reason is set but iscsit_process_scsi_cmd() is
not called. This means that the "if (cmd->reject_reason) ..." code
in this function can be removed without changing the behavior of
this function.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Andy Grover <agrover@redhat.com>
Cc: David Disseldorp <ddiss@suse.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target.c

index 735d4ff2d0cec1d6f794761354c106c452aa12ca..74e4975dd1b1e74d6c39517be102ccdc92614e80 100644 (file)
@@ -1249,12 +1249,8 @@ int iscsit_process_scsi_cmd(struct iscsi_conn *conn, struct iscsi_cmd *cmd,
         * execution.  These exceptions are processed in CmdSN order using
         * iscsit_check_received_cmdsn() in iscsit_get_immediate_data() below.
         */
-       if (cmd->sense_reason) {
-               if (cmd->reject_reason)
-                       return 0;
-
+       if (cmd->sense_reason)
                return 1;
-       }
        /*
         * Call directly into transport_generic_new_cmd() to perform
         * the backend memory allocation.