eth: fs_enet: fix print format for resource size
authorJakub Kicinski <kuba@kernel.org>
Thu, 15 Jun 2023 03:52:31 +0000 (20:52 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 16 Jun 2023 05:54:06 +0000 (22:54 -0700)
Randy reported that linux-next build warns on PowerPC:

drivers/net/ethernet/freescale/fs_enet/mii-fec.c: In function 'fs_enet_mdio_probe':
drivers/net/ethernet/freescale/fs_enet/mii-fec.c:130:50: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Wformat=]
  130 |         snprintf(new_bus->id, MII_BUS_ID_SIZE, "%x", res.start);
      |                                                 ~^   ~~~~~~~~~
      |                                                  |      |
      |                                                  |      resource_size_t {aka long long unsigned int}
      |                                                  unsigned int
      |                                                 %llx

Use the right print format.

Link: https://lore.kernel.org/all/8f9f8d38-d9c7-9f1b-feb0-103d76902d14@infradead.org/
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Link: https://lore.kernel.org/r/20230615035231.2184880-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fs_enet/mii-fec.c

index d37d7a1..59a8f0b 100644 (file)
@@ -127,7 +127,7 @@ static int fs_enet_mdio_probe(struct platform_device *ofdev)
        if (ret)
                goto out_res;
 
-       snprintf(new_bus->id, MII_BUS_ID_SIZE, "%x", res.start);
+       snprintf(new_bus->id, MII_BUS_ID_SIZE, "%pap", &res.start);
 
        fec->fecp = ioremap(res.start, resource_size(&res));
        if (!fec->fecp) {