fs/kernfs/symlink.c: replace S_IRWXUGO with 0777 on kernfs_create_link()
authorLuis Chamberlain <mcgrof@kernel.org>
Mon, 27 Sep 2021 16:38:00 +0000 (09:38 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 5 Oct 2021 14:21:16 +0000 (16:21 +0200)
If one ends up extending this line checkpatch will complain about the
use of S_IRWXUGO suggesting it is not preferred and that 0777
should be used instead. Take the tip from checkpatch and do that
change before we do our subsequent changes.

This makes no functional changes.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Link: https://lore.kernel.org/r/20210927163805.808907-8-mcgrof@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/kernfs/symlink.c

index c8f8e41..19a6c71 100644 (file)
@@ -36,8 +36,7 @@ struct kernfs_node *kernfs_create_link(struct kernfs_node *parent,
                gid = target->iattr->ia_gid;
        }
 
-       kn = kernfs_new_node(parent, name, S_IFLNK|S_IRWXUGO, uid, gid,
-                            KERNFS_LINK);
+       kn = kernfs_new_node(parent, name, S_IFLNK|0777, uid, gid, KERNFS_LINK);
        if (!kn)
                return ERR_PTR(-ENOMEM);