Staging: lustre: Use list_{next/prev}_entry instead of list_entry
authorBhumika Goyal <bhumirks@gmail.com>
Sun, 6 Mar 2016 14:56:58 +0000 (20:26 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 Mar 2016 06:09:09 +0000 (22:09 -0800)
This patch replace list_entry with list_{next/prev}_entry as it makes
the code more clear to read.
Done using coccinelle:

@@
expression e1;
identifier e3;
type t;
@@
(
- list_entry(e1->e3.next,t,e3)
+ list_next_entry(e1,e3)
|
- list_entry(e1->e3.prev,t,e3)
+ list_prev_entry(e1,e3)
)

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_proto.c
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c

index 976a072..4499b1b 100644 (file)
@@ -60,8 +60,7 @@ ksocknal_next_tx_carrier(ksock_conn_t *conn)
                /* no more packets queued */
                conn->ksnc_tx_carrier = NULL;
        } else {
-               conn->ksnc_tx_carrier = list_entry(tx->tx_list.next,
-                                                      ksock_tx_t, tx_list);
+               conn->ksnc_tx_carrier = list_next_entry(tx, tx_list);
                LASSERT(conn->ksnc_tx_carrier->tx_msg.ksm_type == tx->tx_msg.ksm_type);
        }
 }
index 488523d..ecd65a7 100644 (file)
@@ -890,8 +890,7 @@ static void search_granted_lock(struct list_head *queue,
        list_for_each(tmp, queue) {
                lock = list_entry(tmp, struct ldlm_lock, l_res_link);
 
-               mode_end = list_entry(lock->l_sl_mode.prev,
-                                         struct ldlm_lock, l_sl_mode);
+               mode_end = list_prev_entry(lock, l_sl_mode);
 
                if (lock->l_req_mode != req->l_req_mode) {
                        /* jump to last lock of mode group */
@@ -911,9 +910,7 @@ static void search_granted_lock(struct list_head *queue,
                if (lock->l_resource->lr_type == LDLM_IBITS) {
                        for (;;) {
                                policy_end =
-                                       list_entry(lock->l_sl_policy.prev,
-                                                      struct ldlm_lock,
-                                                      l_sl_policy);
+                                       list_prev_entry(lock, l_sl_policy);
 
                                if (lock->l_policy_data.l_inodebits.bits ==
                                    req->l_policy_data.l_inodebits.bits) {