b43legacy: Fix error due to MMIO access with SSB unpowered
authorLarry Finger <Larry.Finger@lwfinger.net>
Sun, 6 May 2012 21:01:05 +0000 (16:01 -0500)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 15 May 2012 21:27:59 +0000 (17:27 -0400)
There is a dummy read of a PCI MMIO register that occurs before the SSB bus
has been powered, which is an error. This bug has not been seen earlier,
but was apparently exposed when udev was updated to version 182.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/b43legacy/main.c

index 1be214b..1deafaa 100644 (file)
@@ -1573,8 +1573,6 @@ static void b43legacy_request_firmware(struct work_struct *work)
        const char *filename;
        int err;
 
-       /* do dummy read */
-       ssb_read32(dev->dev, SSB_TMSHIGH);
        if (!fw->ucode) {
                if (rev == 2)
                        filename = "ucode2";